Closed
Bug 2078317
Opened 1 month ago
Closed 1 month ago
Ads client fails to initialize on Firefox 157 and older
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
159 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr153 | --- | unaffected |
| firefox157 | --- | wontfix |
| firefox158 | --- | unaffected |
| firefox159 | --- | fixed |
People
(Reporter: ahanot, Assigned: ahanot)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 external file)
The backward-compat check in AdsClient.sys.mjs tests MozAdsEnvironment.PROD for truthiness, but its value is 0, so on 157 and older it falls back to new MozAdsEnvironment.Prod(), which doesn't exist there.
| Assignee | ||
Comment 1•1 month ago
|
||
Updated•1 month ago
|
Assignee: nobody → ahanot
Status: NEW → ASSIGNED
Comment 2•1 month ago
|
||
Set release status flags based on info from the regressing bug 2071389
status-firefox157:
--- → unaffected
status-firefox158:
--- → affected
status-firefox159:
--- → affected
status-firefox-esr153:
--- → unaffected
Pushed by mconley@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/941f7be8a3ea
https://hg.mozilla.org/integration/autoland/rev/a16ee5d7a517
Fix MozAdsEnvironment.PROD check when its value is 0. r=mconley
Comment 4•1 month ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 159 Branch
Comment 5•1 month ago
|
||
The patch landed in nightly and beta is affected.
:ahanot, please make an uplift decision for beta:
- For beta, nominate the patch for beta uplift approval if the fix should be included in this release, or set
status-firefox158towontfixif the fix can wait for the next release.
See Requesting an Uplift for documentation on how to request an uplift.
For more information, please visit BugBot documentation.
Flags: needinfo?(ahanot)
Comment 6•1 month ago
|
||
The Rust-based change that is required by the AdsClient.sys.mjs library landed in 158 in bug 2071389, so 158 is not affected.
Updated•1 month ago
|
Flags: needinfo?(ahanot)
Updated•1 month ago
|
Updated•29 days ago
|
QA Whiteboard: [qa-triage-done-c160/b159]
You need to log in
before you can comment on or make changes to this bug.
Description
•