Skip to content

clang-tidy: Apply modernize-redundant-void-arg everywhere. - #6446

Merged
JohannesLorenz merged 3 commits into
LMMS:masterfrom
irrenhaus3:modernize-redundant-void-arg
Jun 23, 2022
Merged

JohannesLorenz merged 3 commits into
LMMS:masterfrom
irrenhaus3:modernize-redundant-void-arg

Conversation

@irrenhaus3

Copy link
Copy Markdown
Contributor

This refactor transforms function declarations (and friends) of the form T foo(void); into T foo();. The void keyword is redundant there, since the declaration is equivalent to one with an empty argument list.

@LmmsBot

LmmsBot commented Jun 23, 2022 •

Copy link
Copy Markdown
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Windows

Linux

🤖
{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/048e165a-8f36-4624-963b-ddb1b6851262/artifacts/0/lmms-1.3.0-alpha.1.203+g691771737-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17461?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/3ec1a632-44c8-4964-8fe5-a634161efa09/artifacts/0/lmms-1.3.0-alpha.1.203+g691771737-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17462?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://output.circle-artifacts.com/output/job/d3240699-35d4-4960-a22b-eebab2df7d9e/artifacts/0/lmms-1.3.0-alpha.1.203+g691771737-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17464?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "76019ffbc2114c1565a5244e6de043d6770038af"}

@JohannesLorenz

Copy link
Copy Markdown
Contributor

Code is OK, but what about something like sed 's#( )#()#' ? 😁

@irrenhaus3

Copy link
Copy Markdown
Contributor Author

You got it.

@JohannesLorenz
JohannesLorenz merged commit 7733103 into LMMS:master Jun 23, 2022
sakertooth pushed a commit to sakertooth/lmms that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂