Repository navigation
Don't auto-quantize notes when recording MIDI input - #6714
Conversation
|
Sorry I didn't participate in the discussion of the topic, but what about having a variable in the MIDI Setting section so that the user can set the default behavior according to their preferences? Many people can't play the piano proficiently, and I think quantization is a great help (it's true that you can quantize later, but it might not be seen as a good alternative for some people). |
I'm not a good piano player myself (like, at all, I just hit chords along with the song playback 😄), but for me, the mode of recording freeform first and then moving & quantizing where needed is the only one that feels "right". Everything else feels like the software getting in the way instead of helping me with what I want to do. |
|
I'm not against having it to "Off" by default, but I think that for some people having auto-quantize while recording can be seen as a positive feature. |
|
Whatever is the default option, it'd be good if a per-user default value could be configured via the settings. Same with other options like follow-play-marker but I digress. |
70855d4 to
52f530d
Compare
|
I've added a checkbox for this in the MIDI settings. I'm not sure if that's the right place though, kinda feels like this should be a button in the piano roll editor. |
To me is ok to have it in MIDI settings, as per-user configuration better than as per-record configuration (I don't know if that makes sense ;-) |
Style formatting Co-authored-by: saker <sakertooth@gmail.com>
…nd update it on ConfigManager::valueChanged()
sakertooth
left a comment
There was a problem hiding this comment.
Tested and working. Could easily see the improvement made at lower resolutions. Automatic updates of the auto quantization option also works as expected.
One formatting change, and reusing an existing variable instead of introducting a new local one. Co-authored-by: saker <sakertooth@gmail.com> Co-authored-by: IanCaio <iancaio_dev@hotmail.com>
Good catch. Co-authored-by: IanCaio <iancaio_dev@hotmail.com>
IanCaio
left a comment
There was a problem hiding this comment.
Code-wise it LGTM, I didn't manage to test it yet though.
…the PR, and give the setting a default value in SetupDialog constructor.
sakertooth
left a comment
There was a problem hiding this comment.
I'm okay with the new changes 👍
* Don't auto-quantize notes when recording MIDI input. * Add midi:autoquantize to config file and a widget to set it in the MIDI settings. * Quantize notes during recording if midi:autoquantize is enabled. * Apply suggestions from code review: Formatting Style formatting Co-authored-by: saker <sakertooth@gmail.com> * Cache the auto quantization setting in a PianoRoll member variable, and update it on ConfigManager::valueChanged() * Apply suggestions from code review: Formatting & temp variable One formatting change, and reusing an existing variable instead of introducting a new local one. Co-authored-by: saker <sakertooth@gmail.com> Co-authored-by: IanCaio <iancaio_dev@hotmail.com> * Update src/gui/modals/SetupDialog.cpp Good catch. Co-authored-by: IanCaio <iancaio_dev@hotmail.com> * Fix logic bug in PianoRoll's midi/autoquantize value observer. * Use '!' instead of 'not' to please MSVC. * autoquantize: Add an explicit check for consistency with the rest of the PR, and give the setting a default value in SetupDialog constructor. * Integrate MIDI auto-quantize checkbox into the resizable layout, and add a tool tip. --------- Co-authored-by: saker <sakertooth@gmail.com> Co-authored-by: IanCaio <iancaio_dev@hotmail.com>
Relates to issue #6332.
I regularly ran into trouble with the piano roll quantization when recording a MIDI pattern from my controller (meaning I regularly forgot that I sometimes had to manually set quantization to 1/192 before hitting record), which led to me having to throw my pattern away and redo it. Pretty frustrating.
This PR makes only one change: When recording MIDI input in one of the two realtime modes, neither note positions nor lengths are quantized automatically. Makes life a lot easier, so I think it's a worthy change to merge upstream.