Skip to content

Wrap resource urls in double quotes - #6898

Merged
DomClark merged 3 commits into
LMMS:masterfrom
anytizer:qss
Oct 10, 2023
Merged

DomClark merged 3 commits into
LMMS:masterfrom
anytizer:qss

Conversation

@anytizer

@anytizer anytizer commented Sep 25, 2023 •

Copy link
Copy Markdown
Contributor
  1. Wrap resource URLs in double quotes so that IDEs treat these values as string.
  2. alternate-background-color: #111314; from: Add Button 'Hover' effect #6822: Failing css line fix only from this PR

2. alternate-background-color: #111314;: takeover
@DomClark

DomClark commented Oct 6, 2023

Copy link
Copy Markdown
Member

Should the classic theme be updated too?

@anytizer

anytizer commented Oct 7, 2023 •

Copy link
Copy Markdown
Contributor Author

It is good to get them updated. But these changes are purely for editor/IDEs only, that will properly colorate values while editing them.

@DomClark

DomClark commented Oct 8, 2023

Copy link
Copy Markdown
Member

Sorry if I was unclear - what I meant was: should the same changes be applied to the classic theme too? It also has some unquoted resource URLs.

@anytizer

anytizer commented Oct 8, 2023

Copy link
Copy Markdown
Contributor Author

Yes, they should be changed in classic theme too.
I have sent another PR for that.

@zonkmachine

Copy link
Copy Markdown
Contributor

I have sent another PR for that.

Those changes belongs to this PR. When you add changes to a branch that has been made into a PR like this one, when you commit the changes and do another push, the changes are added here. No need for a separate PR.

@zonkmachine zonkmachine left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DomClark
DomClark merged commit 84aca0a into LMMS:master Oct 10, 2023
@anytizer
anytizer deleted the qss branch October 11, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂