Repository navigation
Wrap resource urls in double quotes - #6898
Merged
Merged
Conversation
2. alternate-background-color: #111314;: takeover
Member
|
Should the classic theme be updated too? |
Contributor
Author
|
It is good to get them updated. But these changes are purely for editor/IDEs only, that will properly colorate values while editing them. |
Member
|
Sorry if I was unclear - what I meant was: should the same changes be applied to the classic theme too? It also has some unquoted resource URLs. |
Contributor
Author
|
Yes, they should be changed in classic theme too. |
Contributor
Those changes belongs to this PR. When you add changes to a branch that has been made into a PR like this one, when you commit the changes and do another push, the changes are added here. No need for a separate PR. |
DomClark
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.