Repository navigation
Update game-music-emu submodule - #7144
Merged
Merged
Conversation
Veratil
approved these changes
Mar 12, 2024
DomClark
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
game-music-emusubmodule used by FreeBoy has migrated from Bitbucket (https://bitbucket.org/mpyne/game-music-emu) to GitHub (https://github.com/libgme/game-music-emu).This PR modifies our submodule to point to its new GitHub URL and also updates to the latest commit on
game-music-emu's master branch. This lets LMMS incorporate several of the upstream bug fixes for the Game Boy APU emulator that have been made over the years. I do not know yet whether this will resolve any of LMMS's open FreeBoy issues.EDIT: The gme upgrade didn't seem to fix any of the open FreeBoy issues.