Repository navigation
fix(auth): set WebAuthn user verification per request - #38810
Merged
silverwind merged 4 commits intoAug 8, 2026
Merged
Conversation
Registration omitted userVerification, so Chromium raised the discoverable credential to credProtect level 3 and the authenticator then hid it from the second-factor login. Both logins asked for "discouraged", which also lets a client skip verification entirely and makes "alwaysUv" authenticators refuse. Each ceremony now states its own value: "required" to register and for the passkey login, which is single factor, and "preferred" for the second factor, which repairs credentials that were already registered at level 3. Assisted-by: Claude Code:claude-opus-5
Every path that parks a pending sign-in carried its own copy of the session update and the webauthn/two_factor redirect, so they had drifted apart. Route them all through one helper and let each path state whether a factor is still owed, and attach a pending identity only once the factor answered. Follow-up to db9f64e, addressing review feedback. Assisted-by: Claude Code:claude-opus-5
delvh
approved these changes
Aug 7, 2026
lunny
approved these changes
Aug 8, 2026
silverwind
enabled auto-merge (squash)
August 8, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #38805
Registration omitted
userVerification, so Chromium raised the credential to credProtect level 3 and the authenticator then hid it from the second-factor login, which asked fordiscouraged. Registration and each login now set their own value, withpreferredon the second factor so credentials already registered at level 3 keep working without re-enrollment.Also add relevant e2e test coverage for webauthn, one test is chromium only because Firefox lacks the APIs needed.
Fixes #33531
Fixes #36019
Fixes #38139